Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #907 by ensuring the parameters is properly "exploded" #14825

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Fix issue #907 by ensuring the parameters is properly "exploded" #14825

merged 1 commit into from
Jun 23, 2023

Conversation

GregDThomas
Copy link
Contributor

@GregDThomas GregDThomas commented Feb 27, 2023 •
edited
Loading

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script : 
    ./bin/utils/ensure-up-to-date.sh
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10)

This PR ensures that an exploded query parameter is properly handled by the java-resttemplate code generator, fixing #907

@GregDThomas GregDThomas changed the title Fix https://github.com/OpenAPITools/openapi-generator/issues/970 by e… Fix https://github.com/OpenAPITools/openapi-generator/issues/907 by e… Feb 28, 2023
@GregDThomas GregDThomas mentioned this pull request Feb 28, 2023
Open
@GregDThomas GregDThomas force-pushed the rest-template-explode-correctly branch 3 times, most recently from d96844b to c28c265 Compare March 1, 2023 02:03
@GregDThomas GregDThomas changed the title Fix https://github.com/OpenAPITools/openapi-generator/issues/907 by e… Fix issue #907 by ensuring the parameters is properly "exploded" Mar 1, 2023
@GregDThomas GregDThomas force-pushed the rest-template-explode-correctly branch 3 times, most recently from 82b5d96 to 30789e4 Compare March 1, 2023 05:01
@GregDThomas GregDThomas marked this pull request as ready for review March 1, 2023 14:48
@GregDThomas GregDThomas mentioned this pull request Mar 2, 2023
Open
@wing328 wing328 added this to the 6.5.0 milestone Mar 14, 2023
@wing328
Copy link
Member

wing328 commented Mar 14, 2023

@GregDThomas thanks for the PR. Can you please PM me via Slack when you've time?

https://join.slack.com/t/openapi-generator/shared_invite/zt-12jxxd7p2-XUeQM~4pzsU9x~eGLQqX2g

@GregDThomas GregDThomas force-pushed the rest-template-explode-correctly branch from 30789e4 to 4216ad6 Compare March 31, 2023 12:38
@GregDThomas
Copy link
Contributor Author

Just rebased this - is there anything additional I need to do in order to get this merged. Thank you!

@GregDThomas GregDThomas mentioned this pull request Mar 31, 2023
Closed
6 tasks
@wing328 wing328 modified the milestones: 6.5.0, 6.6.0 Apr 1, 2023
@wing328 wing328 modified the milestones: 6.6.0, 7.0.0 May 11, 2023
@wing328 wing328 merged commit 5d6b769 into OpenAPITools:master Jun 23, 2023
@gcatanese
Copy link
Contributor

@wing328 @GregDThomas Using lombok.SneakyThrows, is this correct?

@GregDThomas
Copy link
Contributor Author

It was certainly intentional on my behalf. I wouldn’t use it in production code, but IMHO it’s fine in test classes. I also suspect (but can’t check right now) it’s probably used elsewhere in the tests too.

@gcatanese
Copy link
Contributor

Ok, I see, thanks

@gcatanese
Copy link
Contributor

The only way I can get it working is to add the lombok dependency in the POM file. Any idea what goes wrong?

@GregDThomas
Copy link
Contributor Author

Lombok certainly used to be a dependency, as the PR would never have compiled without it. I can’t readily check until next week, but It’s possible that since raising the PR and getting it merged Lombok was removed. A sort of invisible merge conflict I guess.

@wing328
Copy link
Member

wing328 commented Jun 24, 2023

Added back lombok to pom.xml via 17c2401

@gcatanese
Copy link
Contributor

Sorted now, thank you both

@GregDThomas
Copy link
Contributor Author

Thank you, and apology for the mess up.

fmoraespadtec pushed a commit to padteclab/openapi-generator that referenced this pull request Jun 26, 2023
@GregDThomas
Fix issue OpenAPITools#907 by ensuring the parameters is properly "ex…
315da54 
…ploded" (OpenAPITools#14825)
@dreambrother dreambrother mentioned this pull request Dec 20, 2023
Merged
5 tasks
@jorgerod jorgerod mentioned this pull request Jan 8, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Client: Java Issue: Bug
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@GregDThomas @wing328 @gcatanese